linux-kernel - Re: [PATCH] ALSA: hda: fix kstrdup return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h8uagl7lc.wl-tiwai@suse.de>
Date:	Thu, 16 Jul 2015 12:28:31 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	kernelpatch_update <kernelpatch_update@....com>
Cc:	perex@...ex.cz, david.henningsson@...onical.com,
	kailang@...ltek.com, hui.wang@...onical.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: fix kstrdup return value

On Thu, 16 Jul 2015 12:27:07 +0200,
Takashi Iwai wrote:
> 
> On Thu, 16 Jul 2015 03:04:10 +0200,
> kernelpatch_update wrote:
> > 
> > In kstrdup we should return -ENOMEM when it reports an 
> > memory allocation failure, while the -ENODEV is referred
> > to a failure in finding the cpu node in the device tree.
> > 
> > Signed-off-by: kernelpatch_update <kernelpatch_update@....com>
> 
> Thanks, applied now.

Erm, no, sorry, it's not applicable.  The sign-off must contain the
real name.

Could you resubmit with the proper sign off?


thanks,

Takashi


> Takashi
> 
> > ---
> >  sound/pci/hda/hda_codec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> > index 5de3c5d..d78fa71 100644
> > --- a/sound/pci/hda/hda_codec.c
> > +++ b/sound/pci/hda/hda_codec.c
> > @@ -975,7 +975,7 @@ int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card,
> >  	if (codec->bus->modelname) {
> >  		codec->modelname = kstrdup(codec->bus->modelname, GFP_KERNEL);
> >  		if (!codec->modelname) {
> > -			err = -ENODEV;
> > +			err = -ENOMEM;
> >  			goto error;
> >  		}
> >  	}
> > -- 
> > 1.9.1
> > 
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/