linux-kernel - Re: [PATCH] gpio: pca953x: Fix warning when HW interrupts are rescheduled by the softirq tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbK4tXMuwMsXqmp=2-EkPC=95cK=Q8SMzv6ms3XnEDEMg@mail.gmail.com>
Date:	Thu, 16 Jul 2015 14:39:28 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Grygorii Strashko <grygorii.strashko@...com>
Cc:	Christian Gmeiner <christian.gmeiner@...il.com>,
	Lothar Waßmann <LW@...o-electronics.de>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH] gpio: pca953x: Fix warning when HW interrupts are
 rescheduled by the softirq tasklet

On Tue, Jul 7, 2015 at 12:00 PM, Grygorii Strashko
<grygorii.strashko@...com> wrote:
> On 07/07/2015 09:29 AM, Christian Gmeiner wrote:

>> Linus, what is the state of the your last thinking about this topic?
>
> Could you try if below change works for you, pls (not tested):
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index d233eb3..ac29308 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -570,6 +570,9 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
>                                 "could not connect irqchip to gpiochip\n");
>                         return ret;
>                 }
> +
> +               gpiochip_set_chained_irqchip(&chip->gpio_chip, &pca953x_irq_chip,
> +                                            client->irq, NULL);

Looks like it works, can you send a proper patch?

(Maybe there is one in my inbox, whatdoIknow...)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/