linux-kernel - Re: [PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write / register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150716125254.GE4039@sirena.org.uk>
Date:	Thu, 16 Jul 2015 13:52:54 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nariman Poushin <nariman@...nsource.wolfsonmicro.com>
Cc:	gregkh@...uxfoundation.org, airlied@...ux.ie,
	dmitry.torokhov@...il.com, sameo@...ux.intel.com,
	lee.jones@...aro.org, tony@...mide.com, lgirdwood@...il.com,
	brian.austin@...rus.com, Paul.Handrigan@...rus.com,
	support.opensource@...semi.com, bardliao@...ltek.com,
	oder_chiou@...ltek.com, laurent.pinchart+renesas@...asonboard.com,
	lars@...afoo.de, dmurphy@...com, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	patches@...nsource.wolfsonmicro.com, linux-omap@...r.kernel.org,
	alsa-devel@...a-project.org, peter.ujfalusi@...com
Subject: Re: [PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write /
 register_patch

On Tue, Jul 14, 2015 at 03:45:51PM +0100, Nariman Poushin wrote:

Please submit patches in the format covered in SubmittingPatches,
version information goes inside the [].

> Add support for writing sequences of registers / patches with specified
> delays (in microseconds). Logically separates the functionality using
> sequences of register writes from the functions that take register
> defaults, as adding a delay field on the reg_defaults can increase
> memory usage substantially.

This change doesn't do what the above changelog says.  It introduces a
new struct reg_sequence and updates the multi write and patch APIs to
use that but it doesn't implement any delay functionality.  Please
resend with a clearer changelog that describes why the struct is being
split out from the reg_defaults struct and makes it clear that this is
just a rename.  It's probably best to also defer the addition of the
delay field until the second patch where this function is actually
implemented.

> +/**
> + * Register / Value pairs for sequences of writes, incorporating an optional

Register/value.

> + * delay in microseconds.
> + *
> + * @reg: Register address.
> + * @def: Register default value.
> + * @delay_us: Delay in microseconds
> + */
> +
> +struct reg_sequence {

No blank line between the kerneldoc and the struct (as is the style for
other kernel code).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)