linux-kernel - RE: [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <000301d0bfd2$8b701440$a2503cc0$@opengridcomputing.com>
Date:	Thu, 16 Jul 2015 09:20:19 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'Nicholas Krause'" <xerofoify@...il.com>, <swise@...lsio.com>
Cc:	<dledford@...hat.com>, <sean.hefty@...el.com>,
	<hal.rosenstock@...il.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa_reply



> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@...il.com]
> Sent: Wednesday, July 15, 2015 9:38 PM
> To: swise@...lsio.com
> Cc: dledford@...hat.com; sean.hefty@...el.com; hal.rosenstock@...il.com; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa_reply
> 
> This fixes a concurrent access issue in the function send_mpa_reply
> when calling the non wrapper function set_state on the structure
> pointer ep's member com due to us not locking the mutex lock for
> this structure pointer and thus avoid concurrent access issues
> by here by using the wrapper version of set_state that properly
> locks the mutex lock for us.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 3ad8dc7..0b46b99 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -1048,7 +1048,7 @@ static int send_mpa_reply(struct c4iw_ep *ep, const void *pdata, u8 plen)
>  	skb_get(skb);
>  	t4_set_arp_err_handler(skb, NULL, arp_failure_discard);
>  	ep->mpa_skb = skb;
> -	__state_set(&ep->com, MPA_REP_SENT);
> +	state_set(&ep->com, MPA_REP_SENT);
>  	ep->snd_seq += mpalen;
>  	return c4iw_l2t_send(&ep->com.dev->rdev, skb, ep->l2t);
>  }
> --


send_mpa_reply() is called with the ep mutex held.  See c4iw_accept_cr().



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/