linux-kernel - Re: [PATCH V2] acpi-cpufreq: Fix an acpi perf unregister issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10145531.HIolQ1AkeI@vostro.rjw.lan>
Date:	Thu, 16 Jul 2015 02:33:36 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Pan Xinhui <xinhuix.pan@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-pm@...r.kernel.org,
	"yanmin_zhang@...ux.intel.com" <yanmin_zhang@...ux.intel.com>,
	"mnipxh@....com" <mnipxh@....com>
Subject: Re: [PATCH V2] acpi-cpufreq: Fix an acpi perf unregister issue

On Monday, July 13, 2015 07:58:59 AM Viresh Kumar wrote:
> On 10-07-15, 14:36, Pan Xinhui wrote:
> > 
> > As policy->cpu may not be same in acpi_cpufreq_cpu_init and
> > acpi_cpufreq_cpu_exit. There is a risk that we use different *cpu* to
> > un/register acpi performance. So acpi_processor_unregister_performance
> > may not be able to do the cleanup work. That causes a memory leak. And
> > if there will be another acpi_processor_register_performance call, it
> > may also fail thanks to the internal check of pr->performace.
> > 
> > So we add a field *acpi_perf_cpu* to fix this issue.
> > 
> > Signed-off-by: Pan Xinhui <xinhuix.pan@...el.com>
> > ---
> > Change from V1:
> > 	comments update
> > ---
> >  drivers/cpufreq/acpi-cpufreq.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Patch queued up for 4.3, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/