linux-kernel - Re: [PATCH 0/4] block: account io: kill atomic operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A7C449.4030406@kernel.dk>
Date:	Thu, 16 Jul 2015 08:48:41 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <tom.leiming@...il.com>, linux-kernel@...r.kernel.org
CC:	Mike Snitzer <snitzer@...hat.com>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 0/4] block: account io: kill atomic operations

On 07/15/2015 09:16 PM, Ming Lei wrote:
> Hi,
>
> This patches kills two kinds of atomic operations in block
> accounting I/O.
>
> The 1st two patches convert atomic refcount of partition
> into percpu refcount.
>
> The 2nd two patches converts partition->in_flight[] into percpu
> variable.
>
> With this change, ~15% throughput improvement can be observed
> when running fio(randread) over null blk in a dual-socket
> environment.

I've played with this before, but always ran into the hurdle of making 
part_in_flight() too expensive ended up hurting results in the end. 
Making the inc/dec parts of accounting percpu is a no-brainer, 
unfortunately the summing then becomes pretty expensive. I'll run this 
through some testing and see what kind of results I get.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/