linux-kernel - Re: [alsa-devel] [PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write / register_patch

Open Source and information security mailing list archives

Date:	Thu, 16 Jul 2015 16:45:25 +0100
From:	Nariman Poushin <nariman@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	oder_chiou@...ltek.com, brian.austin@...rus.com,
	laurent.pinchart+renesas@...asonboard.com, sameo@...ux.intel.com,
	alsa-devel@...a-project.org, airlied@...ux.ie,
	gregkh@...uxfoundation.org, dri-devel@...ts.freedesktop.org,
	dmitry.torokhov@...il.com, lgirdwood@...il.com,
	Paul.Handrigan@...rus.com, linux-kernel@...r.kernel.org,
	peter.ujfalusi@...com, tony@...mide.com, lars@...afoo.de,
	dmurphy@...com, patches@...nsource.wolfsonmicro.com,
	bardliao@...ltek.com, linux-omap@...r.kernel.org,
	lee.jones@...aro.org, support.opensource@...semi.com
Subject: Re: [alsa-devel] [PATCH 1/2] V4 regmap: Use reg_sequence for
	multi_reg_write / register_patch

On Thu, Jul 16, 2015 at 01:52:54PM +0100, Mark Brown wrote:
> On Tue, Jul 14, 2015 at 03:45:51PM +0100, Nariman Poushin wrote:
> 
> Please submit patches in the format covered in SubmittingPatches,
> version information goes inside the [].
> 
> > Add support for writing sequences of registers / patches with specified
> > delays (in microseconds). Logically separates the functionality using
> > sequences of register writes from the functions that take register
> > defaults, as adding a delay field on the reg_defaults can increase
> > memory usage substantially.
> 
> This change doesn't do what the above changelog says.  It introduces a
> new struct reg_sequence and updates the multi write and patch APIs to
> use that but it doesn't implement any delay functionality.  Please
> resend with a clearer changelog that describes why the struct is being
> split out from the reg_defaults struct and makes it clear that this is
> just a rename.  It's probably best to also defer the addition of the
> delay field until the second patch where this function is actually
> implemented.
> 
> > +/**
> > + * Register / Value pairs for sequences of writes, incorporating an optional
> 
> Register/value.
> 
> > + * delay in microseconds.
> > + *
> > + * @reg: Register address.
> > + * @def: Register default value.
> > + * @delay_us: Delay in microseconds
> > + */
> > +
> > +struct reg_sequence {
> 
> No blank line between the kerneldoc and the struct (as is the style for
> other kernel code).

I realized that I resent my patches with out outlining the changes from
the previous patch set (V5 vs V4), not sure if it is best to resend
with a cover letter (which would increase noise)?

Anyway, I addressed your both your and Takashi's comments, thanks both
for your feedback.

I will resend with a cover letter explaining the change from the previous
patch set if that is the right thing to do.

Thanks
Nariman

> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives