| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150716172124.GK3681@bark> Date: Thu, 16 Jul 2015 18:21:24 +0100 From: Andy Whitcroft <apw@...onical.com> To: Joe Perches <joe@...ches.com> Cc: Viresh Kumar <viresh.kumar@...aro.org>, linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: Checkpatch: False positive On Thu, Jul 16, 2015 at 08:58:56AM -0700, Joe Perches wrote: > On Thu, 2015-07-16 at 16:43 +0100, Andy Whitcroft wrote: > > On Thu, Jul 16, 2015 at 08:35:58AM -0700, Joe Perches wrote: > > > > #31: > > > > arch/x86/kernel/hpet.c | 198 ++++++++++++++++++++++++++--------------- > > > > I guess those are in the limbo land between the end of message and > > beginning of the patch itself. Perhaps the test should at least stop at > > the end of header marker, at the '---'. > > > > -apw > > Maybe, but the test already stops at signatures like > Signed-off-by: that should always be above the ---. > > This might help, but there are _many_ false positives. > > The other thing that might help is for people to take > the warnings the script produces less seriously. > > Maybe convert: > > ERROR -> defect > WARNING -> unstylish > CHECK -> nitpick Heh, that has long been the main issue, please please believe your brain not checkpatch. But yes some less inflamitory words might, just might, reduce the noise. -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists