linux-kernel - Re: [PATCH v4] staging: rtl8192u: remove bool comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150717090713.GA887@goodgumbo.baconseed.org>
Date:	Fri, 17 Jul 2015 11:07:13 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Frans Klaver <fransklaver@...il.com>,
	Antoine Schweitzer-Chaput <antoine@...weitzer-chaput.fr>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Koray Gulcu <koray.gulcu@....edu.tr>,
	Greg Donald <gdonald@...il.com>,
	Lorenzo Stoakes <lstoakes@...il.com>,
	Ebru Akagunduz <ebru.akagunduz@...il.com>,
	Karthik Nayak <karthik.188@...il.com>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH v4] staging: rtl8192u: remove bool comparisons

On Fri, Jul 17, 2015 at 11:34:45AM +0530, Sudip Mukherjee wrote:
> On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote:
> > Remove explicit true/false comparisons to bool variables.
> > 
> > Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> > ---
> <snip>
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> > index b852396..41cf99d 100644
> > --- a/drivers/staging/rtl8192u/r8192U_core.c
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -2043,16 +2043,10 @@ static bool GetNmodeSupportBySecCfg8192(struct net_device *dev)
> >  
> >  static bool GetHalfNmodeSupportByAPs819xUsb(struct net_device *dev)
> >  {
> > -	bool			Reval;
> >  	struct r8192_priv *priv = ieee80211_priv(dev);
> >  	struct ieee80211_device *ieee = priv->ieee80211;
> >  
> > -	if (ieee->bHalfWirelessN24GMode == true)
> > -		Reval = true;
> > -	else
> > -		Reval =  false;
> > -
> > -	return Reval;
> > +	return ieee->bHalfWirelessN24GMode;
> I think this should have been in a separate patch.
> 
> regards
> sudip

That's a good point. It is related but a different fix than removing booolean
comparisons.

Thanks once again for review Sudip :)

Going to send a new version soon,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/