linux-kernel - Re: [PATCH 2/2] mem-hotplug: Handle node hole when initializing numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Jul 2015 11:10:11 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Tang Chen <tangchen@...fujitsu.com>
cc:	mingo@...hat.com, hpa@...or.com, akpm@...ux-foundation.org,
	tj@...nel.org, dyoung@...hat.com, isimatu.yasuaki@...fujitsu.com,
	yasu.isimatu@...il.com, lcapitulino@...hat.com,
	qiuxishi@...wei.com, will.deacon@....com, tony.luck@...el.com,
	vladimir.murzin@....com, fabf@...net.be, kuleshovmail@...il.com,
	bhe@...hat.com, x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH 2/2] mem-hotplug: Handle node hole when initializing
 numa_meminfo.

On Fri, 17 Jul 2015, Tang Chen wrote:
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index d312ae3..c518eb5 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -77,6 +77,8 @@ int memblock_remove(phys_addr_t base, phys_addr_t size);
>  int memblock_free(phys_addr_t base, phys_addr_t size);
>  int memblock_reserve(phys_addr_t base, phys_addr_t size);
>  void memblock_trim_memory(phys_addr_t align);
> +bool memblock_overlaps_region(struct memblock_type *type,
> +			      phys_addr_t base, phys_addr_t size);
  
> -static bool __init_memblock memblock_overlaps_region(struct memblock_type *type,
> +bool __init_memblock memblock_overlaps_region(struct memblock_type *type,
>  					phys_addr_t base, phys_addr_t size)
>  {
>  	unsigned long i;

This is silly. You change that function in the first patch already, so
why don't you make it globally visible there and then have the user.

Other than that:

Acked-by: Thomas Gleixner <tglx@...utronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/