linux-kernel - Re: [PATCH/RFC 12/51] leds: lm3533: Remove work queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717092026.GA28850@localhost>
Date:	Fri, 17 Jul 2015 11:20:26 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	cooloney@...il.com, rpurdie@...ys.net, stsp@...rs.sourceforge.net,
	Andrew Lunn <andrew@...n.ch>, Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH/RFC 12/51] leds: lm3533: Remove work queue

On Fri, Jul 17, 2015 at 10:46:58AM +0200, Jacek Anaszewski wrote:
> From: Andrew Lunn <andrew@...n.ch>
> 
> Now the core implements the work queue, remove it from the driver.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>
> Cc: Johan Hovold <johan@...nel.org>
> ---
>  drivers/leds/leds-lm3533.c |   30 ++++++------------------------
>  1 file changed, 6 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
> index 6e2e020..52496d8 100644
> --- a/drivers/leds/leds-lm3533.c
> +++ b/drivers/leds/leds-lm3533.c
> @@ -17,7 +17,6 @@
 
> @@ -123,27 +119,17 @@ out:
>  	return ret;
>  }
>  
> -static void lm3533_led_work(struct work_struct *work)
> -{
> -	struct lm3533_led *led = container_of(work, struct lm3533_led, work);
> -
> -	dev_dbg(led->cdev.dev, "%s - %u\n", __func__, led->new_brightness);
> -
> -	if (led->new_brightness == 0)
> -		lm3533_led_pattern_enable(led, 0);	/* disable blink */
> -
> -	lm3533_ctrlbank_set_brightness(&led->cb, led->new_brightness);
> -}
> -
>  static void lm3533_led_set(struct led_classdev *cdev,
> -						enum led_brightness value)
> +			   enum led_brightness value)

Unrelated random white-space change.

>  {
>  	struct lm3533_led *led = to_lm3533_led(cdev);
>  
> -	dev_dbg(led->cdev.dev, "%s - %d\n", __func__, value);
> +	dev_dbg(led->cdev.dev, "%s - %u\n", __func__, value);

Also an unrelated change.

> +
> +	if (value == 0)
> +		lm3533_led_pattern_enable(led, 0);	/* disable blink */
>  
> -	led->new_brightness = value;
> -	schedule_work(&led->work);
> +	lm3533_ctrlbank_set_brightness(&led->cb, value);
>  }

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/