linux-kernel - Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Jul 2015 18:58:32 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree

2015-07-17 18:43 GMT+09:00 Mark Brown <broonie@...nel.org>:
> On Fri, Jul 17, 2015 at 02:11:19PM +0900, Krzysztof Kozlowski wrote:
>
>> I wonder why? Isn't the owner needed for module_get/module_put or am I
>> missing something?
>
> The driver core apparently now does this and we shouldn't be doing it
> statically so we get all this code churn.  I'm not sure I understand the
> win TBH.

If you are referring to my recent patchset it was about platform and
i2c drivers where appropriate register functions do it (e.g.
i2c_register_driver()). But regulator_register passes owner from
regulator_desc:
rdev->owner = regulator_desc->owner;
and then calls device_register(). I think the owner for regulator
device won't be set.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/