linux-kernel - Re: [PATCH] mm/rmap: disable preemption for trace_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717103939.GD2561@suse.de>
Date:	Fri, 17 Jul 2015 11:39:39 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH] mm/rmap: disable preemption for trace_tlb_flush()

On Fri, Jul 17, 2015 at 03:12:54PM +0900, Sergey Senozhatsky wrote:
> tlb_flush contains TP_CONDITION(cpu_online(smp_processor_id()))
> which is better be executed with preemption disabled.
> 
> Move trace_tlb_flush(TLB_REMOTE_SHOOTDOWN) in try_to_unmap_flush()
> under get_cpu().
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

Your patch is valid but Sasha also had sent an almost identicial fix a few
hours ago for identical reasons that Andrew picked up. Thanks for sending
it in.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/