linux-kernel - Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Jul 2015 14:14:46 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Laura Abbott <labbott@...oraproject.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...capital.net>
Subject: Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after
 resume


* Borislav Petkov <bp@...en8.de> wrote:

> >  EXPORT_SYMBOL_GPL(__static_cpu_has_safe);
> > +
> > +static void cpu_custom_resume(void)
> 
> Let's call this bsp_resume() as it is run only on the boot CPU.
> 
> > +{
> > +	if (this_cpu->c_resume)
> > +		this_cpu->c_resume(&boot_cpu_data);
> > +}
> 
> So giving boot_cpu_data means, this is the boot CPU but you're assigning it to 
> c_resume() which means, every CPU. What you could do is call the function ptr 
> ->c_bsp_resume like the ->c_bsp_init which we already have so that it is clear 
> that it is run only on the BSP.
> 
> Rest looks ok to me, unless tip guys have a better idea...

Looks good to me!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/