linux-kernel - RE: [PATCH RFC V4 1/4] perf,tools: introduce callgraph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0770188DB27@SHSMSX103.ccr.corp.intel.com>
Date:	Fri, 17 Jul 2015 14:24:30 +0000
From:	"Liang, Kan" <kan.liang@...el.com>
To:	Jiri Olsa <jolsa@...hat.com>
CC:	"acme@...nel.org" <acme@...nel.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"namhyung@...nel.org" <namhyung@...nel.org>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RFC V4 1/4] perf,tools: introduce callgraph_set for
 callgraph option



> > @@ -784,10 +785,11 @@ int record_parse_callchain_opt(const struct
> option *opt __maybe_unused,
> >  	return ret;
> >  }
> >
> > -int record_callchain_opt(const struct option *opt __maybe_unused,
> > +int record_callchain_opt(const struct option *opt,
> >  			 const char *arg __maybe_unused,
> >  			 int unset __maybe_unused)
> >  {
> > +	*(bool *)opt->set = true;
> 
> hum, how does this set callgraph_set ?
> shouldn't it be 'callgraph_set = true' instead?
> 

Right, I mixed the patch with the previous one.
It should be as below.
I will fix it in next version.

Thanks,
Kan
@@ -789,7 +790,9 @@ int record_callchain_opt(const struct option *opt,
                         const char *arg __maybe_unused,
                         int unset __maybe_unused)
 {
-       *(bool *)opt->set = true;
+       struct record_opts *record = (struct record_opts *)opt->value;
+
+       record->callgraph_set = true;
        callchain_param.enabled = true;

        if (callchain_param.record_mode == CALLCHAIN_NONE)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/