linux-kernel - Re: [PATCH/RFC 51/51] leds: ipaq-micro: Mark the LED fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <55A9214E.8060608@samsung.com>
Date:	Fri, 17 Jul 2015 17:37:50 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Stas Sergeev <stsp@...rs.sourceforge.net>,
	jacek.anaszewski@...il.com
Subject: Re: [PATCH/RFC 51/51] leds: ipaq-micro: Mark the LED fast

On 07/17/2015 03:43 PM, Linus Walleij wrote:
> On Fri, Jul 17, 2015 at 10:47 AM, Jacek Anaszewski
> <j.anaszewski@...sung.com> wrote:
>
>> The driver neither sleeps nor uses delays in its brightness_set
>> op. Mark it fast then.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>
>> Cc: Linus Walleij <linus.walleij@...aro.org>
>
> NACK. The functions called in drivers/mfd/ipaq-micro.c are
> not fast, this need to be dropped.

Oops, indeed I missed that it waits for completion.

Thanks for the review.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/