lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Jul 2015 18:57:29 +0300 From: Andrew Vagin <avagin@...il.com> To: Oleg Nesterov <oleg@...hat.com> Cc: Andrey Vagin <avagin@...nvz.org>, linux-kernel@...r.kernel.org, linux-api@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Cyrill Gorcunov <gorcunov@...nvz.org>, Pavel Emelyanov <xemul@...allels.com>, Roger Luethi <rl@...lgate.ch>, Arnd Bergmann <arnd@...db.de>, Arnaldo Carvalho de Melo <acme@...nel.org>, David Ahern <dsahern@...il.com>, Andy Lutomirski <luto@...capital.net>, Pavel Odintsov <pavel.odintsov@...il.com> Subject: Re: [PATCH 08/24] proc: pick out a function to iterate task children On Tue, Jul 14, 2015 at 08:02:35PM +0200, Oleg Nesterov wrote: > On 07/06, Andrey Vagin wrote: > > > > -static struct pid * > > -get_children_pid(struct inode *inode, struct pid *pid_prev, loff_t pos) > > +static struct task_struct * > > +task_next_child(struct task_struct *parent, struct task_struct *prev, unsigned int pos) > > { > > I won't really argue, just a question... > > So this patch changes it to accept/return task_struct rather pid. Why? > it is better to get/put "struct pid" only, not the whole task_struct. > > If another caller want task_struct, the necessary conversion is simple. Another caller wants task_struct. Currently this function receives pid and converts it into task_struct, then gets the next child and returns its pid. So I try to avoid extra conversion in task_diag code. > But again, I won't argue if you think this will complicate the non-proc > users of this helper. > > Oleg. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists