linux-kernel - [RFC PATCH 12/21] sched: Add __schedule() to stackvalidate whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6decd725802447eb2ba0c914c3d70610a606c2b7.1437150175.git.jpoimboe@redhat.com>
Date:	Fri, 17 Jul 2015 11:47:28 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>, x86@...nel.org,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [RFC PATCH 12/21] sched: Add __schedule() to stackvalidate whitelist

stackvalidate reports the following warnings for __schedule():

  stackvalidate: kernel/sched/core.o: __schedule()+0x3e7: duplicate frame pointer save
  stackvalidate: kernel/sched/core.o: __schedule()+0x424: sibling call from callable instruction with changed frame pointer
  stackvalidate: kernel/sched/core.o: __schedule()+0x431: call without frame pointer save/setup
  stackvalidate: kernel/sched/core.o: __schedule()+0x8b8: frame pointer state mismatch
  stackvalidate: kernel/sched/core.o: __schedule()+0x447: frame pointer state mismatch

__schedule() is obviously a special case which is allowed to do unusual
things with the frame pointer.  Add it to the stackvalidate whitelist.
This results in no actual changes to the generated code.

Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
---
 kernel/sched/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 78b4bad10..9f49eae 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -74,6 +74,7 @@
 #include <linux/binfmts.h>
 #include <linux/context_tracking.h>
 #include <linux/compiler.h>
+#include <linux/stackvalidate.h>
 
 #include <asm/switch_to.h>
 #include <asm/tlb.h>
@@ -3059,6 +3060,7 @@ static void __sched __schedule(void)
 
 	balance_callback(rq);
 }
+STACKVALIDATE_IGNORE_FUNC(__schedule);
 
 static inline void sched_submit_work(struct task_struct *tsk)
 {
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/