linux-kernel - Re: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717164927.GA21691@localhost>
Date:	Fri, 17 Jul 2015 09:49:27 -0700
From:	Olof Johansson <olof@...om.net>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Javier Martinez Canillas <javier@...hile0.org>, arm@...nel.org,
	Arnd Bergmann <arnd@...db.de>,
	Kevin Hilman <khilman@...aro.org>,
	Doug Anderson <dianders@...omium.org>,
	Kukjin Kim <kgene@...nel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator,
 rtc and clock drivers

On Thu, Jul 16, 2015 at 09:42:47AM +0900, Krzysztof Kozlowski wrote:
> On 16.07.2015 00:38, Javier Martinez Canillas wrote:
> > Hello,
> > 
> > On Thu, May 14, 2015 at 5:40 PM, Javier Martinez Canillas
> > <javier.martinez@...labora.co.uk> wrote:
> >> The Maxim max77802 Power Management IC is used on many Exynos machines.
> >> Besides a bunch of regulators, this chip has a Real-Time-Clock (RTC)
> >> and 2-channel 32kHz clock outputs.
> >>
> >> Enable the kernel config options to have the drivers for these devices
> >> built as a module.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
> >> ---
> >>  arch/arm/configs/multi_v7_defconfig | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> >> index 2349584b6e08..080120fe5580 100644
> >> --- a/arch/arm/configs/multi_v7_defconfig
> >> +++ b/arch/arm/configs/multi_v7_defconfig
> >> @@ -373,6 +373,7 @@ CONFIG_POWER_RESET_SYSCON=y
> >>  CONFIG_REGULATOR_MAX8907=y
> >>  CONFIG_REGULATOR_MAX8973=y
> >>  CONFIG_REGULATOR_MAX77686=y
> >> +CONFIG_REGULATOR_MAX77802=m
> > 
> > I noticed that the version that landed in 4.2-rc1 as commit
> > f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 regulator, rtc
> > and clock drivers") doesn't include this symbol. I guess it was caused
> > by a wrong resolved conflict? I'll post a patch to enable the
> > regulator again.
> 
> As you can see in mentioned mainline commit Kukjin removed it manually:
> [kgene@...nel.org: removing useless REGULATOR_MAX77802 config]
> 
> I wonder why?

Seems odd. exynos_defconfig still enables it.

Javier or Krzysztof, please send an incremental fix to enable and I'll pick
it up as a fix.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/