linux-kernel - Re: [PATCH V6 4/4] audit: avoid double copying the audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2210388.jZFblZFq4z@sifl>
Date:	Fri, 17 Jul 2015 14:01:47 -0400
From:	Paul Moore <pmoore@...hat.com>
To:	Richard Guy Briggs <rgb@...hat.com>
Cc:	Eric Paris <eparis@...hat.com>, linux-audit@...hat.com,
	linux-kernel@...r.kernel.org, sgrubb@...hat.com
Subject: Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

On Friday, July 17, 2015 12:18:27 PM Richard Guy Briggs wrote:
> On 15/07/16, Eric Paris wrote:
> > I have to admit, I'm partial to not merging this (with the other
> > patches).  Changing object lifetimes in what i seem to remember is long
> > standing code (auditfilter, not auditexe) seems to me like something we
> > really would want to be git bisectable, not mushed with an unrelated
> > feature addition. But it ain't my tree   :)
> 
> So maybe even fixing this before applying the audit exe stuff has
> merit...

No, let's get the exe filter stuff in now just so I can get all you guys off 
my back about it :)

The refcnt stuff is almost surely going to get messy and I would just assume 
not deal with that right now since it appears to be working.  We have other 
stuff we need to fix first.

-- 
paul moore
security @ redhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/