linux-kernel - Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717181122.GT11162@sirena.org.uk>
Date:	Fri, 17 Jul 2015 19:11:22 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Xing Zheng <zhengxing@...k-chips.com>
Cc:	dgreid@...omium.org, dianders@...omium.org, heiko@...ech.de,
	sonnyrao@...omium.org, linux-rockchip@...ts.infradead.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650
 codec

On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote:
> From: zhengxing <zhengxing@...k-chips.com>
> 
> The driver is used for rockchip board using a rt5645/rt5650.

Same comments here, mostly good but some minor issues.  The other thing
with both of these is that you need to have a binding document for them.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)