[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALCETrVSJAWH7RutVeXd_Y1bdOdw_-5gv6iDspyf0p8k2D8EyA@mail.gmail.com>
Date: Fri, 17 Jul 2015 12:01:55 -0700
From: Andy Lutomirski <luto@...capital.net>
To: Brian Gerst <brgerst@...il.com>
Cc: X86 ML <x86@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...nel.org>,
"H. Peter Anvin" <hpa@...or.com>,
Denys Vlasenko <dvlasenk@...hat.com>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct
On Thu, Jul 16, 2015 at 4:46 AM, Brian Gerst <brgerst@...il.com> wrote:
> Allocate a separate structure for the vm86 fields.
>
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -315,12 +315,12 @@ check_v8086_mode(struct pt_regs *regs, unsigned long address,
> {
> unsigned long bit;
>
> - if (!v8086_mode(regs))
> + if (!v8086_mode(regs) || !tsk->thread.vm86)
> return;
>
What's this for? Shouldn't that "if (!v8086_mode(regs) ||
WARN_ON(!tsk->thread.vm86))"?
--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists