linux-kernel - Re: [PATCH v9 7/7] staging: fpga manager: add driver for socfpga fpga manager

Open Source and information security mailing list archives

Date:	Fri, 17 Jul 2015 16:42:16 -0500
From:	atull <atull@...nsource.altera.com>
To:	Moritz Fischer <moritz.fischer@...us.com>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	<jgunthorpe@...idianresearch.com>, <hpa@...or.com>,
	Michal Simek <monstr@...str.eu>,
	Michal Simek <michal.simek@...inx.com>,
	<rdunlap@...radead.org>, <mark.rutland@....com>,
	<linux-doc@...r.kernel.org>, <rubini@...dd.com>,
	<pantelis.antoniou@...sulko.com>, <s.trumtrar@...gutronix.de>,
	<devel@...verdev.osuosl.org>, <sameo@...ux.intel.com>,
	<nico@...aro.org>, <ijc+devicetree@...lion.org.uk>,
	<kyle.teske@...com>, <grant.likely@...aro.org>,
	<davidb@...eaurora.org>, <linus.walleij@...aro.org>,
	<cesarb@...arb.net>, <devicetree@...r.kernel.org>,
	<jason@...edaemon.net>, <pawel.moll@....com>,
	<iws@...o.caltech.edu>, <broonie@...nel.org>,
	Philip Balister <philip@...ister.org>,
	Petr Cvek <petr.cvek@....cz>, <dinguyen@...nsource.altera.com>,
	<pavel@...x.de>, <linux-kernel@...r.kernel.org>, <balbi@...com>,
	<delicious.quinoa@...il.com>, <robh+dt@...nel.org>,
	<rob@...dley.net>, Kumar Gala <galak@...eaurora.org>,
	<akpm@...ux-foundation.org>, <davem@...emloft.net>,
	<m.chehab@...sung.com>
Subject: Re: [PATCH v9 7/7] staging: fpga manager: add driver for socfpga
 fpga manager

On Fri, 17 Jul 2015, Moritz Fischer wrote:

Hi Moritz,

> Alan,
> 
> it looks pretty good so far. I have worked with Michal and developed a
> Zynq equivalent against your last
> patchset which can be found in the Xilinx tree now.
> 
> I just briefly glanced the changes below just two nits that caught my eye.
> I'll take a closer look while trying to update the zynq-fpga driver to
> work with your changes.
> 
...
> > +#include <linux/io.h>
> > +#include <linux/module.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/pm.h>
> As you removed the suspend / resume part, do you still need this?
> > +#include <linux/string.h>

Yep, I can take out this include.

> > +
> > +/*
> > + * Prepare the FPGA to receive the configuration data.
> > + */
> > +static int socfpga_fpga_ops_configure_init(struct fpga_manager *mgr, u32 flags,
> > +                                          const char *buf, size_t count)
> Is there a reason buf and count need to be passed here?
> > +{
> > +       struct socfpga_fpga_priv *priv = mgr->priv;
> > +       int ret;

Its to allow .write_init to look at the image header if it needs to.
Not every FPGA manager is going to need buf and count.  This one doesn't
(cyclone5).  Your .write_init can ignore them if you don't need them.

But Arria10 does (that's a separate driver that I didn't include in this
patchset). In that case I need to parse the image header to know whether
the bitstream is compressed, etc. to know how to configure the FPGA
manager registers before the FPGA can receive image data.

Thanks for reviewing!

Alan

> >
> > _______________________________________________
> > devel mailing list
> > devel@...uxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 
> Overall good job, and thanks for pushing this!
> 
> Cheers,
> 
> Moritz
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives