linux-kernel - Re: [PATCH v2 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFDyS3Nuq8FPx4z5GW1Ht+NBGd+8O9rjPZ+DaMU1XU1QYgA=2g@mail.gmail.com>
Date:	Sat, 18 Jul 2015 13:12:53 +0300
From:	Tal Shorer <tal.shorer@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	mingo@...hat.com,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 2/2] tracing: gpio: add Kconfig option for
 enabling/disabling trace events

On second thought, I wonder if the config option shouldn't be in
kernel/trace/Kconfig
Imagine there's an option for every subsystem. Disabling all of them
but the one you actually care about is going to be a mess if they're
scattered all over the place.
Your thoughts?

On Fri, Jul 17, 2015 at 9:36 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Thu, 16 Jul 2015 20:39:36 +0300
> Tal Shorer <tal.shorer@...il.com> wrote:
>
>> Add a new options to gpio Kconfig, CONFIG_GPIO_TRACING, that is used
>> for enabling/disabling compilation of gpio function trace events.
>>
>
> If I can get acks from the gpio maintainers, I can take this in my
> tree, as it depends on code that modifies the core tracing facility.
>
> -- Steve
>
>> Signed-off-by: Tal Shorer <tal.shorer@...il.com>
>> ---
>>  drivers/gpio/Kconfig        | 7 +++++++
>>  include/trace/events/gpio.h | 4 ++++
>>  2 files changed, 11 insertions(+)
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index c1e2ca3..2829e8e 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -88,6 +88,13 @@ config GPIO_SYSFS
>>  config GPIO_GENERIC
>>       tristate
>>
>> +config GPIO_TRACING
>> +     bool "gpio tracing"
>> +     depends on TRACING
>> +     help
>> +       Enable tracing for gpio subsystem
>> +
>> +
>>  # put drivers in the right section, in alphabetical order
>>
>>  config GPIO_DA9052
>> diff --git a/include/trace/events/gpio.h b/include/trace/events/gpio.h
>> index 927a8ad..09af636 100644
>> --- a/include/trace/events/gpio.h
>> +++ b/include/trace/events/gpio.h
>> @@ -1,6 +1,10 @@
>>  #undef TRACE_SYSTEM
>>  #define TRACE_SYSTEM gpio
>>
>> +#ifndef CONFIG_GPIO_TRACING
>> +#define NOTRACE
>> +#endif
>> +
>>  #if !defined(_TRACE_GPIO_H) || defined(TRACE_HEADER_MULTI_READ)
>>  #define _TRACE_GPIO_H
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/