linux-kernel - Re: [RFC PATCH 02/21] stackvalidate: Add C version of STACKVALIDATE_IGNORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150718145654.GC30713@nazgul.tnic>
Date:	Sat, 18 Jul 2015 16:56:54 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Josh Poimboeuf <jpoimboe@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>, x86@...nel.org,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 02/21] stackvalidate: Add C version of
 STACKVALIDATE_IGNORE_INSN

On Fri, Jul 17, 2015 at 11:47:18AM -0500, Josh Poimboeuf wrote:
> Add a C inline asm string version of the STACKVALIDATE_IGNORE_INSN macro
> which tells stackvalidate to ignore the subsequent instruction.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> ---
>  arch/x86/include/asm/stackvalidate.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/x86/include/asm/stackvalidate.h b/arch/x86/include/asm/stackvalidate.h
> index 2d23c23..dac935c 100644
> --- a/arch/x86/include/asm/stackvalidate.h
> +++ b/arch/x86/include/asm/stackvalidate.h
> @@ -23,6 +23,15 @@
>  	.endif
>  .endm
>  
> +#else /* !__ASSEMBLY__ */
> +

#ifdef CONFIG_STACK_VALIDATION

> +#define STACKVALIDATE_IGNORE_INSN				\
> +	".Ltemp" __stringify(__LINE__) ":;"			\
> +	".pushsection __stackvalidate_ignore_insn, \"a\";"	\
> +	_ASM_ALIGN ";"						\
> +	".long .Ltemp" __stringify(__LINE__) " - .;"		\
> +	".popsection;"
> +

#endif


Also, you should end your lines with "\n" so that the .s output looks
a bit more readable, not like now:

#APP
# 30 "./arch/x86/include/asm/arch_hweight.h" 1
        661:
        .Ltemp32:;.pushsection __stackvalidate_ignore_insn, "a"; .balign 8 ;.long .Ltemp32 - .;.popsection;call __sw_hweight32
662:

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/