linux-kernel - Re: [PATCH 5/5] drivers: staging: rtl8192u: fixed coding style issues in r8192U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437178545.2495.105.camel@perches.com>
Date:	Fri, 17 Jul 2015 17:15:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Joseph-Eugene Winzer <m999@...nmailbox.org>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] drivers: staging: rtl8192u: fixed coding style
 issues in r8192U_core.c

On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote:
> Fixed a few lines that were longer than 80 chars.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
[]
> @@ -212,7 +212,9 @@ static void rtl819x_set_channel_map(u8 channel_plan, struct r8192_priv *priv)
>  				    ChannelPlan[channel_plan].Channel[i] >
>  								max_chan)
>  					break;
> -				GET_DOT11D_INFO(ieee)->channel_map[ChannelPlan[channel_plan].Channel[i]] = 1;
> +				GET_DOT11D_INFO(ieee)->
> +					channel_map[ChannelPlan[channel_plan].
> +						Channel[i]] = 1;

That's _very_ not nice to read.

Try using more temporaries instead.

				index = ChannelPlan[channel_plan].Channel[i];
				GET_DOT11D_INFO(ieee)->channel_map[index] = 1;

etc...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/