lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 18 Jul 2015 07:05:36 +0200
From:	Borislav Petkov <>
To:	Josh Poimboeuf <>
Cc:	Thomas Gleixner <>,
	Ingo Molnar <>,
	"H. Peter Anvin" <>, Michal Marek <>,
	Peter Zijlstra <>,
	Andy Lutomirski <>,
	Linus Torvalds <>,
	Andi Kleen <>,
	Pedro Alves <>,,,
Subject: Re: [RFC PATCH 04/21] x86/hweight: Add stack frame dependency for

On Fri, Jul 17, 2015 at 12:32:20PM -0500, Josh Poimboeuf wrote:
> Well, but this isn't some whitelist code to make stackvalidate happy.
> It's actually a real runtime frame pointer bug, and the rsp dependency
> is real.  If it does the call without first creating the stack frame
> then it breaks frame pointer based stack traces.

I think we can live with the stack trace being a little wrong in those
__sw_* variants. And besides, we're talking about the very very small
percentage of machines (which keeps getting smaller) which don't
support POPCNT. And from those, only for the cases where the arg is not
__builtin_constant_p() because there we do the __const_hweight* thing.

I'd prefer to not clutter the code more in that case.


ECO tip #101: Trim your mails when you reply.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists