linux-kernel - Re: [PATCH v3] jhash: Deinline jhash and jhash2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150719.114122.199681184036898625.davem@davemloft.net>
Date:	Sun, 19 Jul 2015 11:41:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dvlasenk@...hat.com
Cc:	tgraf@...g.ch, tom@...bertland.com, alexander.h.duyck@...hat.com,
	kadlec@...ckhole.kfki.hu, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] jhash: Deinline jhash and jhash2

From: Denys Vlasenko <dvlasenk@...hat.com>
Date: Sun, 19 Jul 2015 17:36:00 +0200

> This patch deinlines jhash and jhash2.
> 
> It also removes rhashtable_jhash2(key, length, seed)
> because it was merely calling jhash2(key, length, seed).
> 
> With this .config: http://busybox.net/~vda/kernel_config,
> after deinlining these functions have sizes and callsite counts
> as follows:
> 
> jhash: 297 bytes, 111 calls
> jhash2: 205 bytes, 136 calls
> 
> Total size decrease is about 33,000 bytes:
> 
>     text     data      bss       dec     hex filename
> 90663567 17221960 36659200 144544727 89d93d7 vmlinux5
> 90630370 17221864 36659200 144511434 89d11ca vmlinux.after
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>

No performance metrics at all have been provided, so this should
not be applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/