linux-kernel - question about drivers/dma/dma-jz4780.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1507191104040.2002@localhost6.localdomain6>
Date:	Sun, 19 Jul 2015 11:08:49 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Zubair.Kakakhel@...tec.com
cc:	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: question about drivers/dma/dma-jz4780.c

The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs 
using devm_request_irq.  The probe function then ends with:

err_unregister_dev:
	dma_async_device_unregister(dd);

err_disable_clk:
        clk_disable_unprepare(jzdma->clk);
	return ret;
}

The remove function, on the other hand contains:

        of_dma_controller_free(pdev->dev.of_node);
        devm_free_irq(&pdev->dev, jzdma->irq, jzdma);
        dma_async_device_unregister(&jzdma->dma_device);

The need for calling devm_free_irq explicitly would be that it needs to 
occur before dma_async_device_unregister, to eg avoid a reference to a 
dangling pointer.  But devm_free_irq is implicitly called after the call 
to dma_async_device_unregister at the end of the probe function.  Which 
one is correct?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/