linux-kernel - Re: [PATCH] perf: fix makefile generation under dash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150719191717.GB27893@krava.brq.redhat.com>
Date:	Sun, 19 Jul 2015 21:17:17 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Sergei Trofimovich <siarheit@...gle.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: fix makefile generation under dash

On Sun, Jul 19, 2015 at 10:30:05AM +0100, Sergei Trofimovich wrote:
> Under dash 'echo -n' yields '-n' to stdout.
> Use printf "" instead.

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> 
> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> CC: Ingo Molnar <mingo@...hat.com>
> CC: Arnaldo Carvalho de Melo <acme@...nel.org>
> CC: Jiri Olsa <jolsa@...hat.com>
> CC: Namhyung Kim <namhyung@...nel.org>
> CC: Adrian Hunter <adrian.hunter@...el.com>
> CC: linux-kernel@...r.kernel.org
> Signed-off-by: Sergei Trofimovich <siarheit@...gle.com>
> ---
>  tools/perf/config/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 094ddae..bc0b59e 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -11,7 +11,7 @@ ifneq ($(obj-perf),)
>  obj-perf := $(abspath $(obj-perf))/
>  endif
>  
> -$(shell echo -n > $(OUTPUT).config-detected)
> +$(shell printf "" > $(OUTPUT).config-detected)
>  detected     = $(shell echo "$(1)=y"       >> $(OUTPUT).config-detected)
>  detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
>  
> -- 
> 2.4.6
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/