linux-kernel - Re: [PATCH v2 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150720081020.GD3061@x1>
Date:	Mon, 20 Jul 2015 09:10:20 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] mfd: max77686: Don't suggest in binding to use a
 deprecated property

On Fri, 17 Jul 2015, Javier Martinez Canillas wrote:

> The regulator-compatible property from the regulator DT binding was
> deprecated. But the max77686 DT binding doc still suggest to use it
> instead of the regulator node name's which is the correct approach.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

By convention shouldn't this be buck@1, or something?

Need Mark to look at this.

> ---
> 
> Changes in v2:
> - Add Krzysztof Kozlowski Reviewed-by tag in patch #1.
> 
>  Documentation/devicetree/bindings/mfd/max77686.txt | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt
> index 163bd81a4607..8221102d3fc2 100644
> --- a/Documentation/devicetree/bindings/mfd/max77686.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77686.txt
> @@ -26,7 +26,7 @@ Optional node:
>  	};
>  	refer Documentation/devicetree/bindings/regulator/regulator.txt
>  
> -  The regulator-compatible property of regulator should initialized with string
> +  The regulator node's name should be initialized with a string
>  to get matched with their hardware counterparts as follow:
>  
>  	-LDOn 	:	for LDOs, where n can lie in range 1 to 26.
> @@ -55,16 +55,14 @@ Example:
>  		reg = <0x09>;
>  
>  		voltage-regulators {
> -			ldo11_reg {
> -				regulator-compatible = "LDO11";
> +			ldo11_reg: LDO11 {
>  				regulator-name = "vdd_ldo11";
>  				regulator-min-microvolt = <1900000>;
>  				regulator-max-microvolt = <1900000>;
>  				regulator-always-on;
>  			};
>  
> -			buck1_reg {
> -				regulator-compatible = "BUCK1";
> +			buck1_reg: BUCK1 {
>  				regulator-name = "vdd_mif";
>  				regulator-min-microvolt = <950000>;
>  				regulator-max-microvolt = <1300000>;
> @@ -72,8 +70,7 @@ Example:
>  				regulator-boot-on;
>  			};
>  
> -			buck9_reg {
> -				regulator-compatible = "BUCK9";
> +			buck9_reg: BUCK9 {
>  				regulator-name = "CAM_ISP_CORE_1.2V";
>  				regulator-min-microvolt = <1000000>;
>  				regulator-max-microvolt = <1200000>;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/