linux-kernel - Re: [PATCH] tty: vt: Fix !TASK_RUNNING diagnostic warning from paste

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jul 2015 11:24:39 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Peter Hurley <peter@...leysoftware.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: vt: Fix !TASK_RUNNING diagnostic warning from
 paste_selection()

On 07/13/2015, 02:47 AM, Peter Hurley wrote:
> Pasting text with gpm on a VC produced warning [1]. Reset task state
> to TASK_RUNNING in the paste_selection() loop, if the loop did not
> sleep.
> 
> [1]
> WARNING: CPU: 6 PID: 1960 at /home/peter/src/kernels/mainline/kernel/sched/core.c:7286 __might_sleep+0x7f/0x90()
> do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff8151805e>] paste_selection+0x9e/0x1a0
...
> Signed-off-by: Peter Hurley <peter@...leysoftware.com>
> ---
>  drivers/tty/vt/selection.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
> index ea27804..939c4b6 100644
> --- a/drivers/tty/vt/selection.c
> +++ b/drivers/tty/vt/selection.c
> @@ -356,6 +356,7 @@ int paste_selection(struct tty_struct *tty)
>  			schedule();
>  			continue;
>  		}
> +	       __set_current_state(TASK_RUNNING);

It looks like spaces slipped in.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/