lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <55ACD19F.3050106@suse.com>
Date:	Mon, 20 Jul 2015 12:46:55 +0200
From:	Juergen Gross <jgross@...e.com>
To:	David Vrabel <david.vrabel@...rix.com>,
	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	konrad.wilk@...cle.com, boris.ostrovsky@...cle.com
Subject: Re: [Xen-devel] [PATCH] xen: release lock occasionally during
 ballooning

On 07/20/2015 12:15 PM, David Vrabel wrote:
> On 10/07/15 15:42, Juergen Gross wrote:
>> When dom0 is being ballooned balloon_process() will hold the balloon
>> mutex until it is finished. This will block e.g. creation of new
>> domains as the device backends for the new domain need some
>> autoballooned pages for the ring buffers.
>>
>> Avoid this by releasing the balloon mutex from time to time during
>> ballooning. Add a state variable to indicate one balloon_process()
>> is active to avoid multiple balloon processes fighting for the mutex.
>
> Is this state variable necessary? balloon_process() is a work item so
> there should only be one instance of it running anyway, yes?

Hmm, yes. I've been following the comment above balloon_process()
which suggested the possibility of multiple active instances.

I'll send another version of the patch with an updated comment and
removed state variable.


Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ