linux-kernel - Re: [PATCH v3 26/46] usb: gadget: pch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jul 2015 17:08:13 +0200
From:	Krzysztof Opasiak <k.opasiak@...sung.com>
To:	Robert Baldyga <r.baldyga@...sung.com>, gregkh@...uxfoundation.org,
	balbi@...com
Cc:	Peter.Chen@...escale.com, johnyoun@...opsys.com,
	dahlmann.thomas@...or.de, nicolas.ferre@...el.com,
	cernekee@...il.com, leoli@...escale.com, daniel@...que.org,
	haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
	michal.simek@...inx.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-geode@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	linuxppc-dev@...ts.ozlabs.org, andrzej.p@...sung.com,
	m.szyprowski@...sung.com
Subject: Re: [PATCH v3 26/46] usb: gadget: pch_ud: add ep capabilities support



On 07/15/2015 08:32 AM, Robert Baldyga wrote:
> Convert endpoint configuration to new capabilities model.
>
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> ---
>   drivers/usb/gadget/udc/pch_udc.c | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c
> index 613547f..cc8fb3c 100644
> --- a/drivers/usb/gadget/udc/pch_udc.c
> +++ b/drivers/usb/gadget/udc/pch_udc.c
> @@ -2895,11 +2895,21 @@ static void pch_udc_pcd_reinit(struct pch_udc_dev *dev)
>   		ep->in = ~i & 1;
>   		ep->ep.name = ep_string[i];
>   		ep->ep.ops = &pch_udc_ep_ops;
> -		if (ep->in)
> +		if (ep->in) {
>   			ep->offset_addr = ep->num * UDC_EP_REG_SHIFT;
> -		else
> +			ep->ep.caps.dir_in = true;
> +		} else {
>   			ep->offset_addr = (UDC_EPINT_OUT_SHIFT + ep->num) *
>   					  UDC_EP_REG_SHIFT;
> +			ep->ep.caps.dir_out = true;
> +		}
> +		if (i == UDC_EP0IN_IDX || i == UDC_EP0OUT_IDX) {
> +			ep->ep.caps.type_control = true;

In all previous patches you set both dir_in and dir_out to true for ep0 
but in this patch you don't do this. Is there some reason for this or 
it's just a mistake?

> +		} else {
> +			ep->ep.caps.type_iso = true;
> +			ep->ep.caps.type_bulk = true;
> +			ep->ep.caps.type_int = true;
> +		}
>   		/* need to set ep->ep.maxpacket and set Default Configuration?*/
>   		usb_ep_set_maxpacket_limit(&ep->ep, UDC_BULK_MAX_PKT_SIZE);
>   		list_add_tail(&ep->ep.ep_list, &dev->gadget.ep_list);
>

Best Regards,

-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/