linux-kernel - Re: [PATCH 1/3] clocksource: atmel-st: Remove irq handler when clock event is unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jul 2015 21:37:26 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	David Dueck <davidcdueck@...glemail.com>
Subject: Re: [PATCH 1/3] clocksource: atmel-st: Remove irq handler when clock
 event is unused

On 20/07/2015 at 11:04:30 +0200, Thomas Gleixner wrote :
> That's why I used setup/remove_irq() in the stale RT changes.
> 

Hum, actually, you hit the same thing with setup/remove_irq (and I'm not sure
to follow why):

BUG: sleeping function called from invalid context at mm/slab.c:2863
in_atomic(): 1, irqs_disabled(): 128, pid: 596, name: sh
CPU: 0 PID: 596 Comm: sh Tainted: G        W       4.1.0-rc4+ #122
Hardware name: Atmel AT91RM9200
[<c000ebd4>] (unwind_backtrace) from [<c000ca64>] (show_stack+0x10/0x14)
[<c000ca64>] (show_stack) from [<c008a0c8>] (__kmalloc+0x38/0x104)
[<c008a0c8>] (__kmalloc) from [<c00d8770>] (__proc_create+0x11c/0x194)
[<c00d8770>] (__proc_create) from [<c00d8b44>] (proc_mkdir_data+0x30/0x9c)
[<c00d8b44>] (proc_mkdir_data) from [<c0042a00>] (register_handler_proc+0xfc/0x10c)
[<c0042a00>] (register_handler_proc) from [<c003f0b0>] (__setup_irq+0x438/0x518)
[<c003f0b0>] (__setup_irq) from [<c003f1e8>] (setup_irq+0x58/0x84)
[<c003f1e8>] (setup_irq) from [<c02de298>] (atmel_st_request_irq+0x4c/0x84)
[<c02de298>] (atmel_st_request_irq) from [<c02de338>] (clkevt32k_set_periodic+0x14/0x54)
[<c02de338>] (clkevt32k_set_periodic) from [<c00509a0>] (clockevents_switch_state+0x1c/0x58)
[<c00509a0>] (clockevents_switch_state) from [<c0050584>] (__clockevents_unbind+0xb8/0xfc)
[<c0050584>] (__clockevents_unbind) from [<c0054954>] (smp_call_function_single+0x34/0x44)
[<c0054954>] (smp_call_function_single) from [<c00506b0>] (sysfs_unbind_tick_dev+0xe8/0x114)
[<c00506b0>] (sysfs_unbind_tick_dev) from [<c00e1748>] (kernfs_fop_write+0x118/0x174)
[<c00e1748>] (kernfs_fop_write) from [<c008df00>] (__vfs_write+0x24/0xdc)
[<c008df00>] (__vfs_write) from [<c008e5f8>] (vfs_write+0xa4/0x128)
[<c008e5f8>] (vfs_write) from [<c008ecf4>] (SyS_write+0x40/0x78)
[<c008ecf4>] (SyS_write) from [<c000a240>] (ret_fast_syscall+0x0/0x30)


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/