linux-kernel - Re: [PATCH] lib/show_mem.c: correct reserved memory calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150720154816.685e70f38e6d0238e3efef91@linux-foundation.org>
Date:	Mon, 20 Jul 2015 15:48:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Vishnu Pratap Singh <vishnu.ps@...sung.com>
Cc:	linux@...musvillemoes.dk, riel@...hat.com,
	isimatu.yasuaki@...fujitsu.com, aquini@...hat.com,
	linux-kernel@...r.kernel.org, cpgs@...sung.com,
	vishu13285@...il.com, pintu.k@...sung.com, rohit.kr@...sung.com
Subject: Re: [PATCH] lib/show_mem.c: correct reserved memory calculation

On Mon, 20 Jul 2015 14:44:25 +0530 Vishnu Pratap Singh <vishnu.ps@...sung.com> wrote:

> CMA reserved memory is not part of total reserved memory.
> Currently when we print the total reserve memory it considers
> cma as part of reserve memory and do minus of totalcma_pages
> from reserved, which is wrong. In cases where total reserved
> is less than cma reserved we will get negative values & while
> printing we print as unsigned and we will get a very large value.
> 
> Below is the show mem output on X86 ubuntu based system where
> CMA reserved is 100MB (25600 pages) & total reserved is ~40MB(10316 pages).
> And reserve memory shows a large value because of this bug.
> 
> Before:
> [  127.066430] 898908 pages RAM
> [  127.066432] 671682 pages HighMem/MovableOnly
> [  127.066434] 4294952012 pages reserved
> [  127.066436] 25600 pages cma reserved
> 
> After:
> [   44.663129] 898908 pages RAM
> [   44.663130] 671682 pages HighMem/MovableOnly
> [   44.663130] 10316 pages reserved
> [   44.663131] 25600 pages cma reserved
> 
> Also this patch change printk to pr_info.

The pr_info change was irritating - it makes it quite hard to see the
functional change.  Please don't mix changes like this, unless the
unrelated changes are trivial and don't hamper review.

This is what the patch actually does:

--- a/lib/show_mem.c~lib-show_memc-correct-reserved-memory-calculation
+++ a/lib/show_mem.c
@@ -38,11 +38,9 @@ void show_mem(unsigned int filter)
 
 	printk("%lu pages RAM\n", total);
 	printk("%lu pages HighMem/MovableOnly\n", highmem);
+	printk("%lu pages reserved\n", reserved);
 #ifdef CONFIG_CMA
-	printk("%lu pages reserved\n", (reserved - totalcma_pages));
 	printk("%lu pages cma reserved\n", totalcma_pages);
-#else
-	printk("%lu pages reserved\n", reserved);
 #endif
 #ifdef CONFIG_QUICKLIST
 	printk("%lu pages in pagetable cache\n",
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/