linux-kernel - Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150721063155.GA7949@gmail.com>
Date:	Tue, 21 Jul 2015 08:31:55 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Brian Gerst <brgerst@...il.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct


* Ingo Molnar <mingo@...nel.org> wrote:

> * Brian Gerst <brgerst@...il.com> wrote:
> 
> > Allocate a separate structure for the vm86 fields.
> 
> Why is this allocated dynamically? This structure is not very large, and a hole 
> in thread_struct isn't that big of an issue - compared to additional fragility 
> introduced by the (mostly untested by normal apps) dynamic allocation here ...
> 
> I don't mind the introduction of the sub-structure in itself, but please embedd 
> it in thread_struct.

Otherwise I have no objections to the rest of the series, nice fixes!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/