linux-kernel - Re: [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1437466481.28284.39.camel@perches.com>
Date:	Tue, 21 Jul 2015 01:14:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Vinay Simha BN <simhavcs@...il.com>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Teddy Wang <teddy.wang@...iconmotion.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER" 
	<linux-fbdev@...r.kernel.org>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars

On Tue, 2015-07-21 at 13:10 +0530, Vinay Simha BN wrote:
> scripts/checkpatch.pl kernel coding style fixes of WARNING

Please run your patches through scripts/checkpatch.pl --strict

> diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
> index b7cf6b2..abad4fe 100644
> --- a/drivers/staging/sm750fb/ddk750_power.h
> +++ b/drivers/staging/sm750fb/ddk750_power.h
> @@ -12,9 +12,9 @@ DPMS_t;
>  #define setDAC(off) \
>  		{	\
>  		POKE32(MISC_CTRL, FIELD_VALUE(PEEK32(MISC_CTRL), \
> -									MISC_CTRL,	\
> -									DAC_POWER,	\
> -									off));	\
> +			MISC_CTRL,	\
> +			DAC_POWER,	\
> +			off));		\

This is used only once and might be better expanded
in-place instead.

It's a single statement macro and doesn't need
braces or a terminating ; and it shouldn't be
indented 2 tabs.

#define setDAC(off)							\
	POKE32(MISC_CTRL,						\
	       FIELD_VALUE(PEEK32(MISC_CTRL), MISC_CTRL, DAC_POWER,	\
			   off))

> diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
[]
> @@ -5,10 +5,11 @@
[]
> +	SII164_HOTPLUG_DISABLE = 0, /* Disable Hot Plug output bit
> +					(always high) */

comment style isn't correct
etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/