linux-kernel - Re: [PATCH] selftests/futex: Fix futex_cmp_requeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55AD9379.7030206@osg.samsung.com>
Date:	Mon, 20 Jul 2015 18:34:01 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Darren Hart <dvhart@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
CC:	David Binderman <dcb314@...mail.com>,
	Linux API Mailing List <linux-api@...r.kernel.org>
Subject: Re: [PATCH] selftests/futex: Fix futex_cmp_requeue_pi() error handling

On 07/20/2015 04:48 PM, Darren Hart wrote:
> An earlier (pre-kernel-integration) refactoring of this code mistakenly
> replaced the error condition, <, with a >. Use < to detect an error as
> opposed to a successful requeue or signal race.
> 
> Reported-by: David Binderman <dcb314@...mail.com>
> Cc: Shuah Khan <shuahkh@....samsung.com>
> Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
> ---
>  .../selftests/futex/functional/futex_requeue_pi_signal_restart.c        | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c b/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c
> index 7f0c756..3d7dc6a 100644
> --- a/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c
> +++ b/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c
> @@ -191,7 +191,7 @@ int main(int argc, char *argv[])
>  		if (res > 0) {
>  			atomic_set(&requeued, 1);
>  			break;
> -		} else if (res > 0) {
> +		} else if (res < 0) {
>  			error("FUTEX_CMP_REQUEUE_PI failed\n", errno);
>  			ret = RET_ERROR;
>  			break;
> 

Daren,

That is quick. Applied to linux-kselftest fixes for 4.2

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/