linux-kernel - [tip:perf/core] perf strlist: load() should return a negative errno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tip-jntpe2lwg1fxn1bku7uccan0@git.kernel.org>
Date:	Tue, 21 Jul 2015 02:32:20 -0700
From:	tip-bot for Arnaldo Carvalho de Melo <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	jolsa@...hat.com, linux-kernel@...r.kernel.org, mingo@...nel.org,
	fweisbec@...il.com, eranian@...gle.com, adrian.hunter@...el.com,
	acme@...hat.com, namhyung@...nel.org, tglx@...utronix.de,
	dsahern@...il.com, bp@...e.de, hpa@...or.com
Subject: [tip:perf/core] perf strlist: load()
  should return a negative errno

Commit-ID:  ab7322af8c620987ed058e39506c97e5f2d3c65c
Gitweb:     http://git.kernel.org/tip/ab7322af8c620987ed058e39506c97e5f2d3c65c
Author:     Arnaldo Carvalho de Melo <acme@...hat.com>
AuthorDate: Thu, 16 Jul 2015 11:08:34 -0300
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Thu, 16 Jul 2015 11:08:34 -0300

perf strlist: load() should return a negative errno

To match what its users return.

Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Borislav Petkov <bp@...e.de>
Cc: David Ahern <dsahern@...il.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Jiri Olsa <jolsa@...hat.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Stephane Eranian <eranian@...gle.com>
Link: http://lkml.kernel.org/n/tip-jntpe2lwg1fxn1bku7uccan0@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/util/strlist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/strlist.c b/tools/perf/util/strlist.c
index 71f9d10..68ae673 100644
--- a/tools/perf/util/strlist.c
+++ b/tools/perf/util/strlist.c
@@ -72,7 +72,7 @@ int strlist__load(struct strlist *slist, const char *filename)
 	FILE *fp = fopen(filename, "r");
 
 	if (fp == NULL)
-		return errno;
+		return -errno;
 
 	while (fgets(entry, sizeof(entry), fp) != NULL) {
 		const size_t len = strlen(entry);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/