linux-kernel - Re: [rtc-linux] [PATCH 1/4] RTC: fix double free in rtc_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKdAkRQCeZaeZaBB1DzPdcFbk9swdGx9EZ7GU3+3p_eqwxxZPA@mail.gmail.com>
Date:	Mon, 20 Jul 2015 17:42:51 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	RTCLINUX <rtc-linux@...glegroups.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Vasiliy Kulikov <segooon@...il.com>
Subject: Re: [rtc-linux] [PATCH 1/4] RTC: fix double free in
 rtc_register_device() error path

On Mon, Jul 20, 2015 at 5:32 PM, Krzysztof Kozlowski
<k.kozlowski@...sung.com> wrote:
> 2015-07-21 8:02 GMT+09:00 Dmitry Torokhov <dmitry.torokhov@...il.com>:
>> Commit 59cca865f21e9e7beab73fcf79ba4eb776a4c228 correctly noted that naked
>> kfree() should not be used after failed device_register() call, however,
>> while it added the needed put_device() it forgot to remove the original
>> kfree() causing double-free.
>>
>> Cc: Vasiliy Kulikov <segooon@...il.com>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> ---
>>  drivers/rtc/class.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> I think it can be cc'ed stable (with fixes tag).

I considered that, but it does not happen on normally working systems.
I'll leave it up to maintainers to annotate as they see fit.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/