linux-kernel - Re: [PATCH] ppc4xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150721094706.GB32172@nazgul.tnic>
Date:	Tue, 21 Jul 2015 11:47:06 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Michael Walle <michael@...le.cc>
Cc:	linux-kernel@...r.kernel.org,
	Doug Thompson <dougthompson@...ssion.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	linux-edac@...r.kernel.org
Subject: Re: [PATCH] ppc4xx_edac: Fix kernel oops

On Tue, Jul 21, 2015 at 11:00:53AM +0200, Michael Walle wrote:
> The commit de3910eb79ac8c0f29a11224661c0ebaaf813039 changed the memory
> allocation for the csrows member. But ppc4xx_edac was forgotten in the
> patch. Fix it.
> 
> This is warning reported by the compiler:
> 
> drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
> drivers/edac/ppc4xx_edac.c:924:28: warning: initialization from
> incompatible pointer type [enabled by default]
>    struct csrow_info *csi = &mci->csrows[row];
> 
> Cc: Doug Thompson <dougthompson@...ssion.com>
> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
> Cc: linux-edac@...r.kernel.org
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  drivers/edac/ppc4xx_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/ppc4xx_edac.c b/drivers/edac/ppc4xx_edac.c
> index 0f04d5e..4c1991d 100644
> --- a/drivers/edac/ppc4xx_edac.c
> +++ b/drivers/edac/ppc4xx_edac.c
> @@ -921,7 +921,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info *mci, u32 mcopt1)
>  	 */
>  
>  	for (row = 0; row < mci->nr_csrows; row++) {
> -		struct csrow_info *csi = &mci->csrows[row];
> +		struct csrow_info *csi = mci->csrows[row];
>  
>  		/*
>  		 * Get the configuration settings for this

Applied, thanks.

Your $Subject says "Fix kernel oops" - do we need to mark this one for
stable? It fixing a real bug and all...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/