linux-kernel - Re: [PATCH 2/2] regulator: MT6311: Add support for MT6311 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1437472339.30329.57.camel@mtksdaap41>
Date:	Tue, 21 Jul 2015 17:52:19 +0800
From:	Henry Chen <HenryC.Chen@...iatek.com>
To:	Mark Brown <broonie@...nel.org>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	Sascha Hauer <kernel@...gutronix.de>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>, <eddie.huang@...iatek.com>,
	<srv_heupstream@...iatek.com>
Subject: Re: [PATCH 2/2] regulator: MT6311: Add support for MT6311 regulator

On Mon, 2015-07-20 at 18:31 +0100, Mark Brown wrote:
> On Mon, Jul 20, 2015 at 03:36:33PM +0800, Henry Chen wrote:
> 
> > @@ -460,6 +460,15 @@ config REGULATOR_MT6397
> >  	  This driver supports the control of different power rails of device
> >  	  through regulator interface.
> >  
> > +config REGULATOR_MT6311
> > +	tristate "MediaTek MT6311 PMIC"
> 
> Please keep these files sorted, MT6311 should be before MT6397.
> 
> > +static struct mt6311_pdata *mt6311_parse_regulators_dt(
> > +		struct device *dev)
> > +{
> > +	struct mt6311_pdata *pdata;
> > +	struct device_node *node;
> > +	int i, num, n;
> > +
> > +	node = of_get_child_by_name(dev->of_node, "regulators");
> > +	if (!node) {
> > +		dev_err(dev, "regulators node not found\n");
> > +		return ERR_PTR(-ENODEV);
> > +	}
> > +
> > +	num = of_regulator_match(dev, node, mt6311_matches,
> > +				 ARRAY_SIZE(mt6311_matches));
> 
> Please convert this to use the modern method of specifying the regulator
> DT bindings by providing of_match and regulators_node in the
> regulator_desc so the core does the mapping for yand regulators_node in
> the regulator_desc so the core does the mapping for yand regulators_node
> in the regulator_desc so the core does the mapping for yand
> regulators_node in the regulator_desc so the core does the mapping for
> you and you can delete the DT handling code.
> 
> Otherwise this driver looks good.

Ok, I will correct these on next version.

Thanks,
Henry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/