linux-kernel - RE: [PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B254064@SW-EX-MBX02.diasemi.com>
Date:	Tue, 21 Jul 2015 10:15:29 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	Alessandro Zummo <a.zummo@...ertech.it>,
	DEVICETREE <devicetree@...r.kernel.org>,
	LINUXINPUT <linux-input@...r.kernel.org>,
	LINUXKERNEL <linux-kernel@...r.kernel.org>,
	RTCLINUX <rtc-linux@...glegroups.com>,
	David Dajun Chen <david.chen@...semi.com>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Lee Jones <lee.jones@...aro.org>,
	Mark Rutland <mark.rutland@....com>,
	"Pawel Moll" <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063
 RTC driver

On 21 July 2015 11:02, Alexandre Belloni wrote:

Hi Alexandre,

Thanks for your help on this
I will send patch v3 with the following changes ...
 
> On 21/07/2015 at 10:43:10 +0100, S Twiss wrote :
> > -	if (val & (DA9063_E_ALARM))
> > +	if (val & (config->rtc_event_alarm_mask))
> unneeded parenthesis here

changed to this:
-       if (val & (config->rtc_event_alarm_mask))
+       if (val & config->rtc_event_alarm_mask)

> > +	if (of_device_is_compatible(pdev->dev.of_node, "dlg,da9063-rtc")) {
> > +		struct da9063 *chip = dev_get_drvdata(pdev->dev.parent);
> > +
> > +		if (chip->variant_code == PMIC_DA9063_AD)
> > +			rtc->config = &da9063_ad_regs;
> > +	} else
> > +		rtc->config = match->data;
> 
> Both arms of the if should use braces.
> Also, what happens if it is a da9063, BB variant? I guess rtc->config
> will not be set.
> maybe you should write:
> 
> rtc->config = match->data;
> if (of_device_is_compatible(pdev->dev.of_node, "dlg,da9063-rtc")) {
>      struct da9063 *chip = dev_get_drvdata(pdev->dev.parent);
> 
>      if (chip->variant_code == PMIC_DA9063_AD)
>          rtc->config = &da9063_ad_regs;
> }

Sure, that is more efficient. No need for an else and explicitly defaulting the BB
register mappings.

+       rtc->config = match->data;
        if (of_device_is_compatible(pdev->dev.of_node, "dlg,da9063-rtc")) {
                struct da9063 *chip = dev_get_drvdata(pdev->dev.parent);
 
                if (chip->variant_code == PMIC_DA9063_AD)
                        rtc->config = &da9063_ad_regs;
-       } else
-               rtc->config = match->data;
+       }

> >  MODULE_AUTHOR("S Twiss <stwiss.opensource@...semi.com>");
> >  MODULE_DESCRIPTION("Real time clock device driver for Dialog DA9063");
> > -MODULE_LICENSE("GPL v2");
> > +MODULE_LICENSE("GPL");
> 
> This should be part of the license change.

Sure:
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");

Regards,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/