linux-kernel - Re: [PATCH] netcp:Fix error handling in the function netcp_xgbe_serdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55AE5DD4.3060304@ti.com>
Date:	Tue, 21 Jul 2015 10:57:24 -0400
From:	Murali Karicheri <m-karicheri2@...com>
To:	Nicholas Krause <xerofoify@...il.com>, <w-kwok2@...com>
CC:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] netcp:Fix error handling in the function netcp_xgbe_serdes_config

On 07/20/2015 11:54 AM, Nicholas Krause wrote:
> This fixes error handling in the function netcp_xgbe_serdes_config
> by putting the return value of netcp_xgbe_serdes_check_lane into
> the variable ret and return this value to the caller as this function
> can fail when called by returning the error code -ETIMEOUT.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>   drivers/net/ethernet/ti/netcp_xgbepcsr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/netcp_xgbepcsr.c b/drivers/net/ethernet/ti/netcp_xgbepcsr.c
> index 33571ac..0c79e3d 100644
> --- a/drivers/net/ethernet/ti/netcp_xgbepcsr.c
> +++ b/drivers/net/ethernet/ti/netcp_xgbepcsr.c
> @@ -483,7 +483,7 @@ static int netcp_xgbe_serdes_config(void __iomem *serdes_regs,
>   		return ret;
>
>   	netcp_xgbe_serdes_enable_xgmii_port(sw_regs);
> -	netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs);
> +	ret = netcp_xgbe_serdes_check_lane(serdes_regs, sw_regs);
>   	return ret;
>   }
>
>
Nicholas,

Thanks for the patch.

Acked-by: Murali Karicheri <m-karicheri2@...com>

-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/