linux-kernel - Re: [PATCH RFC V5 2/4] perf,tool: per-event time support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150721145945.GC21171@krava.brq.redhat.com>
Date:	Tue, 21 Jul 2015 16:59:45 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	"Liang, Kan" <kan.liang@...el.com>
Cc:	Namhyung Kim <namhyung@...nel.org>,
	"acme@...nel.org" <acme@...nel.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC V5 2/4] perf,tool: per-event time support

On Tue, Jul 21, 2015 at 03:39:17AM +0000, Liang, Kan wrote:

SNIP

> > +		case PERF_EVSEL__CONFIG_TERM_PERIOD:
> > +			attr->sample_period = term->val.period;
> > +		default:
> > +			break;
> > +		}
> > +	}
> > +}
> > +
> >  /*
> >   * The enable_on_exec/disabled value strategy:
> >   *
> > @@ -773,6 +789,8 @@ void perf_evsel__config(struct perf_evsel *evsel,
> > struct record_opts *opts)
> >  		attr->use_clockid = 1;
> >  		attr->clockid = opts->clockid;
> >  	}
> > +
> > +	apply_config_terms(attr, &evsel->config_terms);
> >  }
> > 
> 
> Other options/event modifier may also change the sample_period.
> E.g. sample read.
> So I think we may move it to the beginning of perf_evsel__config.

well, it's at the end to ensure we do the event specific setting
after everything else is done

if you set this together with group leader sampling for non leader
event, I guess you know what you're doing.. right?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/