linux-kernel - Re: [PATCH 2/2] tracing: Introduce two additional marks for delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DF5B19AF-BE3F-44A5-9986-EA3F13F02BE9@gmail.com>
Date:	Wed, 22 Jul 2015 00:17:09 +0900
From:	Jungseok Lee <jungseoklee85@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org,
	Byungchul Park <byungchul.park@....com>
Subject: Re: [PATCH 2/2] tracing: Introduce two additional marks for delay

On Jul 22, 2015, at 12:09 AM, Steven Rostedt wrote:
> On Tue, 21 Jul 2015 23:56:31 +0900
> Jungseok Lee <jungseoklee85@...il.com> wrote:
> 
> 
> 
>> Recently, I've noticed that there is a minor, not logical, flaw in the
>> above hunk as reviewing patches which do not get any signals yet. It is
>> a lack of 's' in msec in comment. That is, my latest one is as follows.
>> 
>> +	MARK(100000000ULL	, '@'), /* 100 msecs */
>> +	MARK(10000000ULL	, '*'), /* 10 msecs */ 
>> 
>> I know it's definitely trivial, but I've updated it to align with other
>> comments and planned to resend the patch. Surprisingly, this patch
>> has been already staged on your repo. So, I leave a whole patch again
>> including your SOB since I don't know how to handle this.
>> 
>> Thanks you for reviewing my patch!
> 
> The original is in the process of going through my tests. I waited till
> rc3 to come out to rebase all my work on it (including this patch) and
> restated testing again. I tripped on some things that are still buggy
> in -rc3 (which delays the finishing of my testing).
> 
> As it is in the testing phase, I wont be modifying it. If you want,
> just send another patch on top of my ftrace/core branch, and I can add
> that to my queue too.

Thanks for a kind explanation.
I think it is not needed to create another patch for only this change.

Best Regards
Jungseok Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/