linux-kernel - Re: [PATCH 6/8] IB/mlx5/hmm: add mlx5 HMM device initialization and callback v3.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 10:06:09 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Jerome Glisse <jglisse@...hat.com>
Cc:	Haggai Eran <haggaie@...lanox.com>, linux-kernel@...r.kernel.org,
	linux-rdma@...r.kernel.org, Christophe Harle <charle@...dia.com>,
	Duncan Poole <dpoole@...dia.com>,
	Sherry Cheung <SCheung@...dia.com>,
	Subhash Gutti <sgutti@...dia.com>,
	John Hubbard <jhubbard@...dia.com>,
	Mark Hairgrove <mhairgrove@...dia.com>,
	Lucien Dunning <ldunning@...dia.com>,
	Cameron Buschardt <cabuschardt@...dia.com>,
	Arvind Gopalakrishnan <arvindg@...dia.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Liran Liss <liranl@...lanox.com>
Subject: Re: [PATCH 6/8] IB/mlx5/hmm: add mlx5 HMM device initialization and
 callback v3.

On Tue, Jul 21, 2015 at 11:14:59AM -0400, Jerome Glisse wrote:
> This is a rebase error. But the #error is there for a purpose the HMM
> would not work mid way so if anyone if bisecting up through that i would
> rather error out at compilation.

Add the kconfig option last not first?

Also, can you use 'if (IS_ENABLED(XXX))' as much as possible? Some of
the existing ODP checks looked like it should use that as well..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/