linux-kernel - Re: [PATCH] hid: Drop owner assignment from i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150721173924.GD6121@mail.corp.redhat.com>
Date:	Tue, 21 Jul 2015 13:39:24 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Antonio Borneo <borneo.antonio@...il.com>,
	Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
	Andrew Duggan <aduggan@...aptics.com>,
	Seth Forshee <seth.forshee@...onical.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	"open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hid: Drop owner assignment from i2c_driver

On Jul 10 2015 or thereabouts, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> ---

BTW, Dmitry took the same in his tree, so I think we are safe here too.

Acked-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin

> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/hid/i2c-hid/i2c-hid.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index f77469d4edfb..dfd679647391 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1167,7 +1167,6 @@ MODULE_DEVICE_TABLE(i2c, i2c_hid_id_table);
>  static struct i2c_driver i2c_hid_driver = {
>  	.driver = {
>  		.name	= "i2c_hid",
> -		.owner	= THIS_MODULE,
>  		.pm	= &i2c_hid_pm,
>  		.acpi_match_table = ACPI_PTR(i2c_hid_acpi_match),
>  		.of_match_table = of_match_ptr(i2c_hid_of_match),
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/