linux-kernel - Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+rBtWhiGdjEi4cANpuu54muv9DtO=q_37eZ70Ou2FuDFw@mail.gmail.com>
Date:	Tue, 21 Jul 2015 11:29:56 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Chris J Arges <chris.j.arges@...onical.com>
Cc:	nacc@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org,
	benh@...nel.crashing.org, linux-numa@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead
 of num_possible_nodes

On Tue, Jul 21, 2015 at 10:36 AM, Chris J Arges
<chris.j.arges@...onical.com> wrote:
> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
> assumes the node variable returned by for_each_node will index into
> flow->stats[node].
>
> Use nr_node_ids to allocate a maximal sparse array instead of
> num_possible_nodes().
>
> The crash was noticed after 3af229f2 was applied as it changed the
> node_possible_map to match node_online_map on boot.
> Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861
>
> Signed-off-by: Chris J Arges <chris.j.arges@...onical.com>

Acked-by: Pravin B Shelar <pshelar@...ira.com>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/